FEATURE Added hotkey for AutoTileMainList#871
Draft
Person1873 wants to merge 1 commit intolinuxmint:masterfrom
Draft
FEATURE Added hotkey for AutoTileMainList#871Person1873 wants to merge 1 commit intolinuxmint:masterfrom
Person1873 wants to merge 1 commit intolinuxmint:masterfrom
Conversation
added a very hacky workaround to get an additional hotkey to trigger auto tiling. this was achieved directly in the JS rather than the TS as I wasn't sure how to access the functionality via TS namespacing. I was also unable to get the hotkey to register in the cinnamon shortcut interface for configuration, would appreciate a code review to point out necessary changes for merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a very hacky workaround to get an additional hotkey to trigger auto tiling.
this was achieved directly in the JS rather than the TS as I wasn't sure how to access the functionality via TS namespacing. I was also unable to get the hotkey to register in the cinnamon shortcut interface for configuration, would appreciate a code review to point out necessary changes for merging.
@shuairan could you please advise how this should be done as i'm sure i'm not supposed to edit the JS at all