focus-new-window@mdpenguin: add exclude list setting#986
Open
ChrisB85 wants to merge 5 commits intolinuxmint:masterfrom
Open
focus-new-window@mdpenguin: add exclude list setting#986ChrisB85 wants to merge 5 commits intolinuxmint:masterfrom
ChrisB85 wants to merge 5 commits intolinuxmint:masterfrom
Conversation
Allow users to specify programs whose windows should not receive focus.
Member
|
cc @mdpenguin |
mdpenguin
suggested changes
Dec 9, 2025
Contributor
mdpenguin
left a comment
There was a problem hiding this comment.
This looks useful but I'd prefer to see the following before merging the changes:
- Add
"dependency": "!raiseSome"to the new setting so that it only shows when "Raise windows only of listed programs" is not selected. - Rephrase tooltip to "Comma separated list of programs that should not have their windows automatically receive focus" so that it's not implied that users can't click on the window to give it focus.
- Update the Options section of Readme.md as follows:
## Options
- Raise window only of listed programs
- When selected, only windows from the programs that you list will be affected by the extension
- When unselected, windows from all programs will be affected by the extension unless included in "Programs to exclude"
- Programs to include
- A comma separated list of programs to include
- The list is not case sensitive and spaces between programs is optional
- Programs to exclude
- A comma separated list of programs that should not have their windows automatically receive focus
- The list is not case sensitive and spaces between programs is optional
Author
|
@mdpenguin I made the requested changes and improved the logic so that the include/exclude lists are used depending on the raiseSome setting. |
mdpenguin
approved these changes
Dec 10, 2025
Contributor
mdpenguin
left a comment
There was a problem hiding this comment.
Thanks for making those changes. I'm fine with it as it is, but it might be better to change both the setting element and variable from programList to includeList so that it's consistent and clearer to anyone who works on this in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to specify programs whose windows should not receive focus.
In my case, the extension works correctly with all applications except https://flathub.org/en/apps/com.github.IsmaelMartinez.teams_for_linux, where every message notification caused the application to come into focus. The list of excluded applications solves this problem.