cinnamon-settings: make extension toggles directly clickable#13667
cinnamon-settings: make extension toggles directly clickable#13667jleaders wants to merge 1 commit intolinuxmint:masterfrom
Conversation
Use an inline checkbox for installed extensions so enable and disable actions are visible on each row instead of being hidden behind the bottom toolbar buttons. Made-with: Cursor
|
I personally prefer the +/- buttons here. And even in this case, it doesn't look good in terms of UI imo, probably could be done better with a plus button besides the gear icon, perhaps, which would look disabled once the extension is enabled. It also adds specific complexity to a generic spice settings module. |
|
I like it. An extension is either enabled or disabled unlike the applets and desklets where you can add more than one, so the distinction makes sense. I think it's more intuitive. |
Remember you can restrict applets to one instance too if you want (I think desklets as well), while this could contribute to a specific situation I'm not sure for the generic case. |
|
@anaximeno
Now you just hit the checkbox... like all checkboxes. |
|
To keep things simple. Right now it is consistent with the other spices pages. This change makes it so it isn't. IMHO, it should stay like it is. |
|
jleaders : one info you might be missing, is that while extensions can only be added once, applets and desklets can be added several times, to create multiple instances, so for those, checkboxes can not be used. |
|
Okay, I understand the context now. I opened the desklets page, which I had never used before, and you're right that the plus button can be hit multiple times to add more than one to the desktop. I see how the goal is to keep it consistent across multiple user interface designs. To be honest, I'm a little bit on the fence on the right call. You can't add multiple for the extensions, so the plus/minus just gets confusing in this context. It's a consistency versus usability trade off. Okay, your call. If you want to close this PR I'm fine with it. |
|
One alternative idea I came up with is maybe merge both, keep the checkboxes functional, but make the plus or minus buttons also check or uncheck. So we have consistency but also usability. Let me know, and I can update this PR to match that. |
Removed the +/- buttons and just use clickable checkboxes

Summary
Test plan
cinnamon-settingsPython files onto a local Cinnamon installcinnamon-settings extensions --tab installed+/-buttons are hidden for extensionsMade with Cursor