Skip to content

cinnamon-settings: make extension toggles directly clickable#13667

Open
jleaders wants to merge 1 commit intolinuxmint:masterfrom
jleaders:feature/extensions-manager-clickable-checkbox
Open

cinnamon-settings: make extension toggles directly clickable#13667
jleaders wants to merge 1 commit intolinuxmint:masterfrom
jleaders:feature/extensions-manager-clickable-checkbox

Conversation

@jleaders
Copy link
Copy Markdown

@jleaders jleaders commented Mar 25, 2026

Removed the +/- buttons and just use clickable checkboxes
image

Summary

  • replace the passive enabled indicator in the Extensions list with an inline checkbox
  • wire the checkbox directly to the existing enable/disable logic so extensions can be toggled from the row itself
  • hide the old bottom enable/disable toolbar buttons on the Extensions page so the primary action is easier to discover

Test plan

  • Overlay the modified cinnamon-settings Python files onto a local Cinnamon install
  • Open cinnamon-settings extensions --tab installed
  • Verify the bottom + / - buttons are hidden for extensions
  • Verify clicking the row checkbox enables and disables an extension
  • Verify the configure button sensitivity still tracks the enabled state

Made with Cursor

Use an inline checkbox for installed extensions so enable and disable actions are visible on each row instead of being hidden behind the bottom toolbar buttons.

Made-with: Cursor
@anaximeno
Copy link
Copy Markdown
Contributor

anaximeno commented Mar 27, 2026

I personally prefer the +/- buttons here.

And even in this case, it doesn't look good in terms of UI imo, probably could be done better with a plus button besides the gear icon, perhaps, which would look disabled once the extension is enabled.

It also adds specific complexity to a generic spice settings module.

@fredcw
Copy link
Copy Markdown
Contributor

fredcw commented Mar 27, 2026

I like it. An extension is either enabled or disabled unlike the applets and desklets where you can add more than one, so the distinction makes sense. I think it's more intuitive.

@anaximeno
Copy link
Copy Markdown
Contributor

I like it. An extension is either enabled or disabled unlike the applets and desklets where you can add more than one, so the distinction makes sense. I think it's more intuitive.

Remember you can restrict applets to one instance too if you want (I think desklets as well), while this could contribute to a specific situation I'm not sure for the generic case.

@jleaders
Copy link
Copy Markdown
Author

@anaximeno
I'm a little bit confused why you would prefer a simple checkbox to be checked by a separate plus or minus button in a different location? I'm not joking when I say it actually took me a good fifteen minutes the first time using Cinnamon Spice Extensions to figure out how the heck to enable an extension, because, for starters, a plus button means to "add" something, not to enable something. I had already installed the extension and it was already added and my user intent was not to add a new spice extension, but to enable an existing one, so why would I push a plus button? Well I didn't ... and for fifteen minutes I sat there trying all sorts of different things and even Googling how to enable the extension and get it working. For a while I thought the extension was broken and and had a bug. Nope. It turns out to check a box I have to:

  1. select the row
  2. move my cursor away from the box to the bottom of the UI
  3. hit plus button

Now you just hit the checkbox... like all checkboxes.

@JosephMcc
Copy link
Copy Markdown
Contributor

To keep things simple. Right now it is consistent with the other spices pages. This change makes it so it isn't. IMHO, it should stay like it is.

@pilatomic
Copy link
Copy Markdown

jleaders : one info you might be missing, is that while extensions can only be added once, applets and desklets can be added several times, to create multiple instances, so for those, checkboxes can not be used.

@jleaders
Copy link
Copy Markdown
Author

Okay, I understand the context now. I opened the desklets page, which I had never used before, and you're right that the plus button can be hit multiple times to add more than one to the desktop. I see how the goal is to keep it consistent across multiple user interface designs.

To be honest, I'm a little bit on the fence on the right call. You can't add multiple for the extensions, so the plus/minus just gets confusing in this context. It's a consistency versus usability trade off.

Okay, your call. If you want to close this PR I'm fine with it.

@jleaders
Copy link
Copy Markdown
Author

One alternative idea I came up with is maybe merge both, keep the checkboxes functional, but make the plus or minus buttons also check or uncheck. So we have consistency but also usability. Let me know, and I can update this PR to match that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants