Skip to content

the fix for the boolean uppercase-value attribute validation#9

Open
citysitesdev wants to merge 2 commits into
lireincore:masterfrom
citysites:fix_offer_validation
Open

the fix for the boolean uppercase-value attribute validation#9
citysitesdev wants to merge 2 commits into
lireincore:masterfrom
citysites:fix_offer_validation

Conversation

@citysitesdev

Copy link
Copy Markdown

Оften the logical value of the attribute is written with a capital letter, for example, Truе. However, the validator in "ymlparser" does not pass such values. I suggest the following improvement to be written in /src/Offer/AOffer.php

@vsdm

vsdm commented Sep 25, 2018

Copy link
Copy Markdown

What to do with "tRue"?
I think it should be like this
if ($this->store !== null && strtolower($this->store) !== 'true' && strtolower($this->store) !== 'false')

@shaperman

Copy link
Copy Markdown

What to do with "tRue"?

I believe that in this context "tRue" is a mistake and the result of validation should be negative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants