Fixes XSS in workspace url param#2208
Merged
Merged
Conversation
lissy93
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Security Fix
Overview
As reported by @ixSly in GHSA-58mp-4qr3-vmrc, an authenticated user could click a crafted link taking them to workspace view with ?url= param set which could pass a non-http iframe source.
No stored or zero-click issues identified, and a attacker would already need access to your instance to your network to use this vulnerability.
This PR fixes the issue by fully sanitizing the param.
Issue Number
GHSA-58mp-4qr3-vmrc