Skip to content

feat: add cloud job session controls#523

Merged
cofin merged 7 commits into
mainfrom
codex/adapter-feature-cloud-job-session-controls
Jun 25, 2026
Merged

feat: add cloud job session controls#523
cofin merged 7 commits into
mainfrom
codex/adapter-feature-cloud-job-session-controls

Conversation

@cofin

@cofin cofin commented Jun 13, 2026

Copy link
Copy Markdown
Member

Summary

  • keep BigQuery job retry and timeout controls on the existing query/load/export surfaces instead of adding new public helpers
  • route BigQuery export coverage through the existing select_to_storage path
  • keep Spanner request options, directed reads, retry, and timeout on execute(), execute_many(), execute_script(), and explicit provide_session()/provide_read_session()/provide_write_session() arguments
  • remove the extra Spanner database-operation surface that was outside the existing driver contract

@codecov-commenter

codecov-commenter commented Jun 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.16667% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.34%. Comparing base (fc54103) to head (47a5b61).

Files with missing lines Patch % Lines
sqlspec/adapters/bigquery/core.py 60.71% 4 Missing and 7 partials ⚠️
sqlspec/adapters/spanner/adk/store.py 30.76% 8 Missing and 1 partial ⚠️
sqlspec/adapters/spanner/driver.py 90.76% 3 Missing and 3 partials ⚠️
sqlspec/adapters/spanner/config.py 76.47% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
+ Coverage   75.24%   75.34%   +0.10%     
==========================================
  Files         444      444              
  Lines       58121    58249     +128     
  Branches     8998     9078      +80     
==========================================
+ Hits        43732    43889     +157     
+ Misses      11562    11515      -47     
- Partials     2827     2845      +18     
Flag Coverage Δ
integration 59.42% <27.77%> (-0.08%) ⬇️
py3.10 73.70% <77.08%> (+0.10%) ⬆️
py3.11 73.72% <77.08%> (+0.11%) ⬆️
py3.12 73.71% <77.08%> (+0.10%) ⬆️
py3.13 73.71% <77.08%> (+0.10%) ⬆️
py3.14 74.52% <76.59%> (+0.10%) ⬆️
unit 60.95% <72.22%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sqlspec/adapters/bigquery/config.py 87.58% <100.00%> (+0.08%) ⬆️
sqlspec/adapters/bigquery/driver.py 80.97% <100.00%> (+12.00%) ⬆️
sqlspec/adapters/spanner/config.py 87.35% <76.47%> (-0.89%) ⬇️
sqlspec/adapters/spanner/driver.py 76.66% <90.76%> (+4.49%) ⬆️
sqlspec/adapters/spanner/adk/store.py 61.43% <30.76%> (-0.80%) ⬇️
sqlspec/adapters/bigquery/core.py 69.48% <60.71%> (+6.73%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cofin cofin marked this pull request as ready for review June 13, 2026 19:42
@cofin cofin merged commit 2d377ea into main Jun 25, 2026
22 checks passed
@cofin cofin deleted the codex/adapter-feature-cloud-job-session-controls branch June 25, 2026 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants