Skip to content

test: cover GizmoSQL native metadata fallback#534

Merged
cofin merged 2 commits into
mainfrom
codex/gizmosql-native-metadata-followup
Jun 25, 2026
Merged

test: cover GizmoSQL native metadata fallback#534
cofin merged 2 commits into
mainfrom
codex/gizmosql-native-metadata-followup

Conversation

@cofin

@cofin cofin commented Jun 25, 2026

Copy link
Copy Markdown
Member

Summary

  • add live GizmoSQL/FlightSQL GetObjects coverage for catalog/schema/table/column payload shape
  • document that DuckDB-backed GizmoSQL native metadata is used only when complete, with central dialect SQL fallback for incomplete constraints/nullability
  • keep the follow-up separate from merged PR feat: add native metadata statistics #522

Validation

  • uv run pytest tests/unit/adapters/test_adbc/test_data_dictionary.py tests/integration/adapters/adbc/test_gizmosql_data_dictionary.py (26 passed, 1 xfailed)
  • make docs
  • make lint

@codecov-commenter

codecov-commenter commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.24%. Comparing base (fc54103) to head (d45c4c0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #534      +/-   ##
==========================================
- Coverage   75.24%   75.24%   -0.01%     
==========================================
  Files         444      444              
  Lines       58121    58121              
  Branches     8998     8998              
==========================================
- Hits        43732    43731       -1     
- Misses      11562    11563       +1     
  Partials     2827     2827              
Flag Coverage Δ
integration 59.48% <ø> (-0.03%) ⬇️
py3.10 73.59% <ø> (-0.01%) ⬇️
py3.11 73.60% <ø> (-0.01%) ⬇️
py3.12 73.60% <ø> (-0.01%) ⬇️
py3.13 73.60% <ø> (-0.01%) ⬇️
py3.14 74.41% <ø> (-0.01%) ⬇️
unit 60.74% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cofin cofin merged commit b1a27bb into main Jun 25, 2026
16 checks passed
@cofin cofin deleted the codex/gizmosql-native-metadata-followup branch June 25, 2026 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants