feat(pymssql): add sync SQL Server adapter#570
Draft
cofin wants to merge 1 commit into
Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
==========================================
- Coverage 75.68% 75.03% -0.65%
==========================================
Files 449 464 +15
Lines 59986 61217 +1231
Branches 9144 9265 +121
==========================================
+ Hits 45398 45935 +537
- Misses 11657 12318 +661
- Partials 2931 2964 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pymssqlSQL Server adapter with config, driver, connection pool, migrations, and data dictionary supportTests
uv run pytest tests/unit/adapters/test_pymssql -q --tb=shortuv run ruff check sqlspec/adapters/pymssql tests/unit/adapters/test_pymssqluv run ruff format --check sqlspec/adapters/pymssql tests/unit/adapters/test_pymssqluv run python3 -c "from sqlspec.adapters.pymssql import PymssqlConfig, PymssqlDriver; from sqlspec.adapters.pymssql.adk import PymssqlADKStore; from tests.integration.adapters.contracts._cases import DEFERRED_DRIVER_CASES; assert PymssqlConfig and PymssqlDriver and PymssqlADKStore; assert any(case.id == 'pymssql-sync' for case in DEFERRED_DRIVER_CASES); print('pymssql smoke ok')"