feat(phonic): add additional params support#2022
Closed
rosetta-livekit-bot[bot] wants to merge 1 commit into
Closed
feat(phonic): add additional params support#2022rosetta-livekit-bot[bot] wants to merge 1 commit into
rosetta-livekit-bot[bot] wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 16a3d4a The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Phonic realtime
additionalParamssupport and forwards it asadditional_paramsin config/reset payloads. Updates thephonicSDK dependency to^0.32.9and adds a minor changeset for the new public option.Source diff coverage
Coverage classification
livekit-plugins/livekit-plugins-phonic/livekit/plugins/phonic/realtime/realtime_model.pyplugins/phonic/src/realtime/realtime_model.ts: added publicadditionalParamsoption, stores it on model options, and forwards it to Phonic asadditional_paramsin config payloads.livekit-plugins/livekit-plugins-phonic/pyproject.tomlplugins/phonic/package.jsonandpnpm-lock.yaml: bumped the JSphonicdependency from^0.32.5to^0.32.9, matching the source SDK requirement.No source tests were changed in livekit/agents#6384, so there were no tests to port.
Validation
pnpm --filter @livekit/agents-plugin-phonic testpassed; package has no test script/output.pnpm --filter @livekit/agents-plugin-phonic lintpassed.pnpm --filter @livekit/agents-plugin-phonic buildpassed after building@livekit/agentsdeclarations.pnpm buildpassed.pnpm lintpassed with existing warnings in unrelated packages.pnpm testfailed in unrelated packages/tests: missingCEREBRAS_API_KEY, Silero ONNX fixture/model failures, AMD expectation mismatches, OpenAI STT/VAD setup failure, LiveKit HuggingFace timeout, and example testing failures.Runtime validation
cue-cliis installed and LiveKit credentials are present, but Phonic realtime validation could not be run becausePHONIC_API_KEYis not set in this environment.Ported from livekit/agents#6384
Original PR description
Adds support for
additional_paramsto Phonic's config message.Made with Cursor