Skip to content

chore(deps): update dependency js-yaml@<3.15.0 to v4 [security] #2271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −18
Open

chore(deps): update dependency js-yaml@<3.15.0 to v4 [security] #2271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 9 additions & 17 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ minimumReleaseAgeExclude:
- '@opentelemetry/core@2.8.0'
# Renovate security update: brace-expansion@5.0.8
- brace-expansion@5.0.8
# Renovate security update: js-yaml@4.3.1
- js-yaml@4.3.1

catalog:
'@livekit/rtc-node': ^0.13.33
Expand All @@ -37,7 +39,7 @@ overrides:
'lodash@<4.18.0': ^4.18.0
'protobufjs@<7.6.5': ^7.6.5
'ws@>=8.0.0 <8.21.0': ^8.21.0
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.

@devin-ai-integration devin-ai-integration Bot Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Release tooling crashes because a YAML helper is forced onto an incompatible library version

The old YAML library used by the release tooling is replaced with a version 5 release ('js-yaml@<3.15.0': ^5.0.0 at pnpm-workspace.yaml:42) even though the helper still calls a function that only exists in version 3, so changeset/versioning commands crash.
Impact: Running the changesets release/version commands fails with a runtime error, blocking publishing.

Mechanism: read-yaml-file calls yaml.safeLoad, removed in js-yaml 4/5

@manypkg/get-packages@1.1.3 (a dependency of @changesets/cli) depends on read-yaml-file@1.1.0, whose entire implementation is const parse = data => yaml.safeLoad(stripBom(data)) and which declares js-yaml: ^3.6.1. The override widens that to ^5.0.0, and the lockfile now resolves read-yaml-file@1.1.0 → js-yaml: 5.3.0 (pnpm-lock.yaml:9014-9019). js-yaml removed safeLoad in v4 (verified: require('js-yaml@5.3.0').safeLoad === undefined), so any workspace/package YAML read by changesets throws TypeError: yaml.safeLoad is not a function.

A safer scope would keep the 3.x consumers on a 3.x-compatible line (or pin read-yaml-file to a newer major that uses load), rather than forcing the pre-3.15 range straight to v5.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
'js-yaml@<3.15.0': ^3.15.0
'js-yaml@<3.15.0': ^4.3.1
'js-yaml@>=4.0.0 <4.3.0': ^4.3.0
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment on lines 41 to 43

@devin-ai-integration devin-ai-integration Bot Aug 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟨 Security override does not cover the vulnerable js-yaml 4.3.0 release

The PR bumps js-yaml@<3.15.0 to ^4.3.1 but leaves the 4.x override as 'js-yaml@>=4.0.0 <4.3.0': ^4.3.0 (pnpm-workspace.yaml:43). Since the range excludes 4.3.0 itself, dependencies that resolve to 4.3.0 are not overridden, and pnpm-lock.yaml still installs js-yaml 4.3.0 for @changesets/parse (pnpm-lock.yaml:5768), @eslint/eslintrc (pnpm-lock.yaml:5978) and eslint (pnpm-lock.yaml:7893). Version 4.3.0 is the version listed as affected by GHSA-5p4m-2wfm-xmqj (quadratic CPU consumption in !!omap resolution), so the advisory remains unmitigated in the installed tree.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

'minimatch@<3.1.3': ^3.1.3
'minimatch@>=9.0.0 <9.0.7': ^9.0.7
Expand Down
Loading