fix(amd): start SIP detection after answer#6386
Open
dexhunter wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
active, rather than when its early-media track is subscribedsip_answer_timeoutguard, defaulting to 60 seconds, for calls that never become activeFixes #6187.
Why
Carrier early media can subscribe the audio track well before answer. On the current implementation, that consumes the default 20-second
detection_timeoutduring ringback and can emituncertain/detection_timeoutbefore a late-answering person or voicemail becomes active.This change preserves
detection_timeoutas a post-answer AMD budget. The new answer guard independently bounds calls that never reachactive.Evaluation
The deterministic harness models a SIP track subscribed at
t=0and a call becoming active att=32s:maindetection_timeout_pre_answer_msThe metric is virtual-time based, so it is independent of CPU speed. The strict harness also checks the default and custom answer deadlines, duplicate timer starts, task cancellation, non-SIP behavior, legacy fallback, and all classifier verdict paths.
Validation
make check: formatting, lint, and mypy passed across 617 source filesdetection_timeout_pre_answer_ms=0The deferred-timer and separate-answer-guard direction was identified through autoresearch with Weco. The final patch was reduced and hardened manually against lifecycle and compatibility counterexamples.