Skip to content

fix: add secure context checks for navigator.mediaDevices #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukasIO merged 7 commits into from
Dec 15, 2025
Merged

fix: add secure context checks for navigator.mediaDevices #1769

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
65b4c55
fix: add secure context checks for navigator.mediaDevices
yrendaoai Nov 26, 2025
e225b25
fix: add secure context checks for navigator.mediaDevices
yrendaoai Nov 26, 2025
ee8ce91
refactor: use optional chaining for mediaDevices calls instead of isS…
yrendaoai Nov 27, 2025
cc226fb
refactor: use optional chaining for mediaDevices calls instead of isS…
yrendaoai Nov 27, 2025
abc9a7b
refactor: use optional chaining for mediaDevices calls instead of isS…
yrendaoai Nov 27, 2025
4438fcb
refactor: use optional chaining for mediaDevices calls instead of isS…
yrendaoai Nov 27, 2025
e593aca
refactor: use optional chaining for mediaDevices calls
yrendaoai Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/room/Room.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@
const abortController = new AbortController();

// in order to catch device changes prior to room connection we need to register the event in the constructor
navigator.mediaDevices?.addEventListener('devicechange', this.handleDeviceChange, {
navigator.mediaDevices?.addEventListener?.('devicechange', this.handleDeviceChange, {
signal: abortController.signal,
});

Expand Down Expand Up @@ -1615,7 +1615,7 @@
window.removeEventListener('beforeunload', this.onPageLeave);
window.removeEventListener('pagehide', this.onPageLeave);
window.removeEventListener('freeze', this.onPageLeave);
navigator.mediaDevices?.removeEventListener('devicechange', this.handleDeviceChange);
navigator.mediaDevices?.removeEventListener?.('devicechange', this.handleDeviceChange);
}
} finally {
this.setAndEmitConnectionState(ConnectionState.Disconnected);
Expand Down Expand Up @@ -2499,8 +2499,7 @@
}),
new LocalVideoTrack(
publishOptions.useRealTracks
? (
await window.navigator.mediaDevices.getUserMedia({ video: true })
? (await window.navigator.mediaDevices?.getUserMedia?.({ video: true }) ?? new MediaStream()

Check failure on line 2502 in src/room/Room.ts

View workflow job for this annotation

GitHub Actions / test 

Replace `await·window.navigator.mediaDevices?.getUserMedia?.({·video:·true·})·??` with `⏎················(await·window.navigator.mediaDevices?.getUserMedia?.({·video:·true·}))·??⏎···············`
).getVideoTracks()[0]
Copy link
Contributor Author

@yrendaoai yrendaoai Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The getUserMedia calls with ?? new MediaStream() fallback (lines 2502, 2529)
ensure we don't get undefined when calling .getVideoTracks()[0] in non-secure contexts
where mediaDevices?.getUserMedia?.() returns undefined due to optional chaining.

Copy link
Contributor

@lukasIO lukasIO Nov 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of falling back to new MediaStream() we could simply check for publishOptions.useRealTracks && window.navigator.mediaDevices?.getUserMedia above

: createDummyVideoStreamTrack(
160 * (participantOptions.aspectRatios[0] ?? 1),
Expand Down Expand Up @@ -2528,7 +2527,8 @@
}),
new LocalAudioTrack(
publishOptions.useRealTracks
? (await navigator.mediaDevices.getUserMedia({ audio: true })).getAudioTracks()[0]
? (await navigator.mediaDevices?.getUserMedia?.({ audio: true }) ?? new MediaStream()

Check failure on line 2530 in src/room/Room.ts

View workflow job for this annotation

GitHub Actions / test 

Replace `await·navigator.mediaDevices?.getUserMedia?.({·audio:·true·}` with `⏎················(await·navigator.mediaDevices?.getUserMedia?.({·audio:·true·})`
Copy link
Contributor

@lukasIO lukasIO Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

).getAudioTracks()[0]
: getEmptyAudioStreamTrack(),
undefined,
false,
Expand Down
Loading