SDP: Crypto line, ignore line with session-params#70
Open
ypkoller wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a crypto line in the SDP offer contains
session-params, the parser fails with the following error, causing the connection setup to fail entirely:Cause
The parser incorrectly treats the session parameter (e.g.,
"UNENCRYPTED_SRTCP") as part of the key lifetime, which causesstrconv.ParseUintto fail.Solution / Approach
Since the LiveKit SIP Bridge currently does not process optional session parameters as defined in RFC 4568 Section 6, these crypto lines should be safely ignored rather than causing a hard crash. Aborting the entire parsing process prevents connections from being established, even if there are alternative, valid crypto lines without session parameters available in the SDP offer.