Skip to content

Dynacast support for data tracks#1662

Open
ladvoc wants to merge 4 commits into
mainfrom
ladvoc/data-track-dynacast
Open

Dynacast support for data tracks#1662
ladvoc wants to merge 4 commits into
mainfrom
ladvoc/data-track-dynacast

Conversation

@ladvoc

@ladvoc ladvoc commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Closes BOT-446

@changeset-bot

changeset-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 72d51c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ladvoc
ladvoc marked this pull request as ready for review July 15, 2026 16:13
@ladvoc
ladvoc requested a review from boks1971 July 15, 2026 16:15
optional DataTrackSchemaId schema = 6;

// Whether dynacast is enabled for this track.
bool is_dynacasted = 7;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would drop this if not used. Easier to add later if needed. Just thinking about the feature, this should be needed in the model?

optional DataTrackSchemaId schema = 5;

// Whether dynacast is enabled for this track.
bool is_dynacasted = 6;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.


// Number of participants currently subscribed to the track. Used
// by the publisher when dynacast is enabled for the track.
uint32 subscriber_count = 2;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be a boolean, I think counter is also fine, but it may not be accurate always, but that should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants