Cap RPC payload logging with size-limited proto summaries#1668
Merged
Conversation
psrpc access logs marshal full request/response protos. Unbounded payloads (e.g. large ListEgressResponse pages) produce log lines that exceed collector line limits, getting split into unparseable chunks. Add logger.ProtoWithLimit: when a message's wire size exceeds the limit, log a summary instead — message type, wire size, top-level scalars (sensitivity redaction applied, long strings capped), counts for repeated/map fields. Use it in the psrpc logging interceptors with a 32KB cap. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
zapcore.MapObjectEncoder stores AddInt values as int, not int64. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
paulwe
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The psrpc logging interceptors marshal full request/response protos into every access log line. Payloads of unbounded size — e.g. a
ListEgressResponsepage with 100+ items (~500KB JSON) — produce log lines that exceed the logging backend's per-message limits. The collector splits them into truncated chunks that fail JSON parsing, so they land unstructured with the wrong status, polluting the error stream (and past hard ingestion caps the remainder is silently discarded).Change
logger.ProtoWithLimit(msg, maxBytes): behaves likelogger.Proto, but when the message's wire size exceedsmaxBytesit logs a compact summary instead of the full contents:truncatedProto) and wire size (protoBytes)<field>CountMarshalLogObject, so it costs nothing when the log level is disabled.Example: a truncated
ListEgressResponsenow logs asProto/UnredactedProtoand all other call sites are unchanged.🤖 Generated with Claude Code