-
Notifications
You must be signed in to change notification settings - Fork 208
Update cargo dependencies (livekit-wakeword) #1305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate
wants to merge
1
commit into
main
Choose a base branch
from
renovate/cargo-dependencies-(livekit-wakeword)
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Dependency update ships without the required change note
The dependency version bump for the wake-word package (
resampler = "0.5"atlivekit-wakeword/Cargo.toml:12) is submitted without adding the change note file the project requires for every pull request, so the release tooling will not know this package needs a version bump.Impact: The published package can be released without its dependency change being recorded or its version bumped.
Missing knope changeset entry for livekit-wakeword
AGENTS.md ("Documenting changes") states: "Every PR needs a changeset" and "Changeset must list any crates which need to be bumped stemming from the change". The repository uses knope (
knope.toml) with change notes stored in/.changeset(currentlyfix-publisher-renegotiation-deadlock.md,fix_nvenc_dynamic_bitrate_updates.md,fix_uniffi_android_package_build.md). This commit only touchesCargo.lockandlivekit-wakeword/Cargo.toml(bumpingresampler0.4→0.5 andort-tract0.2→0.3, plus lockfileortrc.11→rc.12) and adds no changeset forlivekit-wakeword.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.