Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions livekit-wakeword/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ license.workspace = true
[dependencies]
ndarray = "0.17.2"
ort = { version = "2.0.0-rc.11", default-features = false, features = ["ndarray", "std"] }
resampler = "0.4"
resampler = "0.5"
thiserror = "2"

[target.'cfg(not(all(target_arch = "aarch64", target_os = "windows", target_env = "msvc")))'.dependencies]
ort = { version = "2.0.0-rc.11", default-features = false, features = ["alternative-backend"] }
ort-tract = "0.2.0+0.22"
ort-tract = "0.3.0"
Comment on lines +12 to +17

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Dependency update ships without the required change note

The dependency version bump for the wake-word package (resampler = "0.5" at livekit-wakeword/Cargo.toml:12) is submitted without adding the change note file the project requires for every pull request, so the release tooling will not know this package needs a version bump.
Impact: The published package can be released without its dependency change being recorded or its version bumped.

Missing knope changeset entry for livekit-wakeword

AGENTS.md ("Documenting changes") states: "Every PR needs a changeset" and "Changeset must list any crates which need to be bumped stemming from the change". The repository uses knope (knope.toml) with change notes stored in /.changeset (currently fix-publisher-renegotiation-deadlock.md, fix_nvenc_dynamic_bitrate_updates.md, fix_uniffi_android_package_build.md). This commit only touches Cargo.lock and livekit-wakeword/Cargo.toml (bumping resampler 0.4→0.5 and ort-tract 0.2→0.3, plus lockfile ort rc.11→rc.12) and adds no changeset for livekit-wakeword.

Prompt for agents
AGENTS.md requires every PR to include a knope changeset in /.changeset listing crates that need a version bump. This PR bumps livekit-wakeword's dependencies (resampler 0.4->0.5, ort-tract 0.2->0.3, and ort rc.11->rc.12 in Cargo.lock) but adds no changeset. Add a changeset file (e.g. via `knope document-change`) noting a patch bump for the livekit-wakeword crate describing the dependency updates.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.


[dev-dependencies]
hound = { workspace = true }
Loading