Skip to content

Update livekit deps #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −12
Open

Update livekit deps #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ require (
github.com/icholy/digest v1.1.0
github.com/jfreymuth/oggvorbis v1.0.5
github.com/livekit/mageutil v0.0.0-20250511045019-0f1ff63f7731
github.com/livekit/media-sdk v0.0.0-20260612175532-3d4d26d136c9
github.com/livekit/media-sdk v0.0.0-20260623124604-40d3338a7426
github.com/livekit/mediatransportutil v0.0.0-20260608063931-a3417d38cda0
github.com/livekit/protocol v1.48.1-0.20260624204523-bd5703442db6
github.com/livekit/protocol v1.48.2
github.com/livekit/psrpc v0.7.2
github.com/livekit/server-sdk-go/v2 v2.16.7-0.20260625120102-b6d1838861e7
github.com/livekit/sipgo v0.13.2-0.20260519205735-a5b4a38b6ceb
github.com/livekit/server-sdk-go/v2 v2.16.7
github.com/livekit/sipgo v0.13.2-0.20250410120437-ca5b8ca7b53d

@devin-ai-integration devin-ai-integration Bot Jul 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 sipgo dependency appears to be downgraded by over a year

The livekit/sipgo pseudo-version changed from v0.13.2-0.20260519205735-a5b4a38b6ceb (May 19, 2026) to v0.13.2-0.20250410120437-ca5b8ca7b53d (April 10, 2025). The go.mod hashes differ (aDa6... vs nbNi...), confirming different source code. The codebase uses several sipgo APIs that may have been introduced after April 2025:

  • sipgo.WithUserAgentTCPConfig, sipgo.TCPConfig, sipgo.PortRange at pkg/sip/service.go:234-237
  • sipgo.WithUserAgenTLSConfig at pkg/sip/service.go:301
  • sipgo.ClientRequestAddVia at pkg/sip/outbound_utilities_test.go:359
  • sipClient.TransportLayer() and tpl.GetConnection() at pkg/sip/outbound.go:1114-1118
  • "github.com/livekit/sipgo/transport" sub-package with transport.UDPMTUSize at pkg/sip/service.go:34,89

If any of these APIs were added between April 2025 and May 2026, this downgrade will cause compilation failures. This should be verified by CI or by checking the sipgo commit history. If this downgrade is intentional (e.g., reverting to a more stable commit), the PR description should explain why.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@devin-ai-integration devin-ai-integration Bot Jul 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 SIP library downgraded to a version that predates required features, breaking the build

The SIP signaling library is downgraded to an April 2025 snapshot (sipgo v0.13.2-0.20250410120437 at go.mod:17) that predates the TCP dial-port-range feature added in December 2025, so the project cannot compile.

Impact: The service fails to build because it references TCP configuration types and options that do not exist in the downgraded library version.

Mechanism: missing TCPConfig, PortRange, and WithUserAgentTCPConfig in older sipgo

The code at pkg/sip/service.go:234-239 uses sipgo.WithUserAgentTCPConfig, sipgo.TCPConfig, and sipgo.PortRange. These were introduced to the sipgo fork in a commit after April 2025 — the feature was added to this repo in commit f40d7bb (December 2025), which simultaneously upgraded sipgo from a June 2025 to a December 2025 version.

The PR downgrades sipgo from v0.13.2-0.20260519205735-a5b4a38b6ceb (May 2026) back to v0.13.2-0.20250410120437-ca5b8ca7b53d (April 2025), which is ~8 months before these APIs existed in the library.

Suggested change
github.com/livekit/sipgo v0.13.2-0.20250410120437-ca5b8ca7b53d
github.com/livekit/sipgo v0.13.2-0.20260519205735-a5b4a38b6ceb
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

github.com/mjibson/go-dsp v0.0.0-20180508042940-11479a337f12
github.com/ory/dockertest/v3 v3.12.0
github.com/pion/rtp v1.10.2
Expand Down
16 changes: 8 additions & 8 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,18 +130,18 @@ github.com/livekit/amrwb-cgo v0.0.0-20260612153743-6d4b69dc1470 h1:pYml12Ue55jDh
github.com/livekit/amrwb-cgo v0.0.0-20260612153743-6d4b69dc1470/go.mod h1:nGBFrVVLyO0RlyM2pWnP/VKaZO6W3rzecL/YlkTPkW8=
github.com/livekit/mageutil v0.0.0-20250511045019-0f1ff63f7731 h1:9x+U2HGLrSw5ATTo469PQPkqzdoU7be46ryiCDO3boc=
github.com/livekit/mageutil v0.0.0-20250511045019-0f1ff63f7731/go.mod h1:Rs3MhFwutWhGwmY1VQsygw28z5bWcnEYmS1OG9OxjOQ=
github.com/livekit/media-sdk v0.0.0-20260612175532-3d4d26d136c9 h1:GVMkuNwXQ74kVPwaXPWfUZR5c9tslhCcgatuHtVUcqY=
github.com/livekit/media-sdk v0.0.0-20260612175532-3d4d26d136c9/go.mod h1:TuYRjSepaakL6ATsM9V2VMuksewW1PlhA32BG7Pxty0=
github.com/livekit/media-sdk v0.0.0-20260623124604-40d3338a7426 h1:MfS6tKsPQOxUMk0iqmauXQfIJpVr6Vkygx44uyM9Whw=
github.com/livekit/media-sdk v0.0.0-20260623124604-40d3338a7426/go.mod h1:TuYRjSepaakL6ATsM9V2VMuksewW1PlhA32BG7Pxty0=
github.com/livekit/mediatransportutil v0.0.0-20260608063931-a3417d38cda0 h1:XHNNzebIKZRkLimla/hFGrAIX5EMWHctrgt3hLw7s+I=
github.com/livekit/mediatransportutil v0.0.0-20260608063931-a3417d38cda0/go.mod h1:o8CFmAdrVwzJNOCsQCLUzXRjokkufNshnQHOe4fRaqU=
github.com/livekit/protocol v1.48.1-0.20260624204523-bd5703442db6 h1:Z23fxGEJJS3akyX2Q6LGo5xfL+B+NcEBhOp5o0Cz5IE=
github.com/livekit/protocol v1.48.1-0.20260624204523-bd5703442db6/go.mod h1:jO+y05AU9Ec4JswDyuzKCZ4bhziOS0CzMqgnbj60Dzs=
github.com/livekit/protocol v1.48.2 h1:1Jv1Eckf2jMN7SgJm7fQkSRQoMkGpmuN63mFeh3gd1U=
github.com/livekit/protocol v1.48.2/go.mod h1:jO+y05AU9Ec4JswDyuzKCZ4bhziOS0CzMqgnbj60Dzs=
github.com/livekit/psrpc v0.7.2 h1:6oZ+NODJ2pLyaT6VqDq1F4Qc/3TpDUSpyphj/P9MhQc=
github.com/livekit/psrpc v0.7.2/go.mod h1:rAI+m2+/cb4x9RXhLRtUx5ZwdfjjXOl4zi46IjEetaw=
github.com/livekit/server-sdk-go/v2 v2.16.7-0.20260625120102-b6d1838861e7 h1:7I1SzZrgyE2PTPzPuWfR+6HO6C7sO0VJb61fUT5KJRw=
github.com/livekit/server-sdk-go/v2 v2.16.7-0.20260625120102-b6d1838861e7/go.mod h1:B3qlhVBZ4olBWRN/KxokLZE2d4LujNk4n2yYDL3+u2s=
github.com/livekit/sipgo v0.13.2-0.20260519205735-a5b4a38b6ceb h1:HmgaJMGs0Nco/Z+XMc9f+xFgrbood9yJsIBtl1OY76M=
github.com/livekit/sipgo v0.13.2-0.20260519205735-a5b4a38b6ceb/go.mod h1:aDa6mbFktNzA1D917RhFlIB5IOfNBTmrwt+/lX960j0=
github.com/livekit/server-sdk-go/v2 v2.16.7 h1:oYnp2o3YTBdL4xVkq5NpLwqnCijZVfVJU9ddFl+BW/Y=
github.com/livekit/server-sdk-go/v2 v2.16.7/go.mod h1:B3qlhVBZ4olBWRN/KxokLZE2d4LujNk4n2yYDL3+u2s=
github.com/livekit/sipgo v0.13.2-0.20250410120437-ca5b8ca7b53d h1:x3JSKtsQpWt/fynro+s7MusrOqIcaGdCnuSXKGEajXc=
github.com/livekit/sipgo v0.13.2-0.20250410120437-ca5b8ca7b53d/go.mod h1:nbNi0IsYn4tyY2ab7Rafvifty07miHYvgedPMKWbaI4=
github.com/mackerelio/go-osstat v0.2.7 h1:TCavZi10wF49bT6iQZ9eT2keGZQpC69MTDfdJej5e94=
github.com/mackerelio/go-osstat v0.2.7/go.mod h1:dwpYh5pIPmvk+IEwBKNIWRFMB92mrC08CmXOhDC7nQk=
github.com/magefile/mage v1.17.2 h1:fyXVu1eadI8Ap1HCCNgEhJ5McIWiYhLR8uol64ZZc40=
Expand Down
Loading