fix: remove obsolete colorscore gem#51
Open
knarewski-livelink wants to merge 7 commits into
Open
Conversation
The wall of text was not particularly easy to use
…pendencies Preinstalling was required, because without a package list the gem was not able to install the dependencies on demand. Another benefit is that the packages will now be cached in the earlier layer, reducing time to install gems
It is long unmaintained, also became obsolete when dominant border colour support was removed: a79d930
The old action was resolving parallel gem to the version incompatible with ruby 2.7, causing errors
Move rubocop to its own bundler group and set BUNDLE_ONLY in the lint job, so it skips the gemspec's native gems and their apt dependencies. Without it, the CI failed due to dependencies installation failures
The alternative was to add tolerance margins, but I opted for better control and visibility for now
knarewski-livelink
force-pushed
the
remove-colorscore
branch
from
d047143 to
91a7a25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reviewing transitive dependencies of another project, I've noticed that
morandidoesn't use colorscore gem anymore, so I removed it.Other piggybacked changes:
parallelonly supporting ruby3.3+)