-
Notifications
You must be signed in to change notification settings - Fork 36
Host allocation follow-on work #1982
Copy link
Copy link
Open
Labels
App IntegrationIssues related to integration with applicationsIssues related to integration with applicationsCoreIssues related to Axom's 'core' componentIssues related to Axom's 'core' componentReviewedmaintenanceIssues related to code maintenanceIssues related to code maintenance
Description
Activity
Metadata
Metadata
Assignees
Labels
App IntegrationIssues related to integration with applicationsIssues related to integration with applicationsCoreIssues related to Axom's 'core' componentIssues related to Axom's 'core' componentReviewedmaintenanceIssues related to code maintenanceIssues related to code maintenance
Noting some additional work items to pursue after #1964 is merged (assuming it does get merged). Rather than address these items in that PR to keep it smaller and focused, these items can be addressed in a future PR. These additional changes affect Axom APIs and semantics when behavior is not explicitly specified.
axom::Array<T>to useAXOM_DEFAULT_HOST_ALLOCATORchoice rather thanMemorySpace::Dynamicso that it's host allocation is consistent with the rest of Axom.AXOM_MALLOCenum value, which does not correspond to a valid Umpire allocator, with the rest of the enum values that do correspond to valid Umpire allocators.setDefaultAllocatortosetUmpireDefaultAllocatorbecause the method only sets the default allocator in the Umpire ResourceManager?Additionally, we will need a good way to test these changes in end user applications to make sure we don't break, or at least help them fix, their assumptions.