[TorchToArith] Implement conversion patterns for AtenSubOp, AtenMulOp, AtenDivOp.
#4396
+86
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junru-Sheng
force-pushed
the
ConvertAtenArith
branch
from
579201a to
39ccd00
Compare
CoTinker
reviewed
Dec 10, 2025
…lOp`, `AtenDivOp`. Implement conversion patterns for `AtenSubOp`, `AtenMulOp`, `AtenDivOp`: Use unified template patterns `ConvertAtenBinaryScalarOp` to handle `AtenAddOp`, `AtenSubOp`, `AtenMulOp`; Use unified template patterns `ConvertAtenDivOp` to handle `AtenDivOp`, `AtenDivIntOp`, `AtenDivFloatOp`.
Junru-Sheng
force-pushed
the
ConvertAtenArith
branch
from
39ccd00 to
f002bbc
Compare
zjgarvey
approved these changes
Dec 10, 2025
Collaborator
|
Looks good, let me know if you want to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement conversion patterns for
AtenSubOp,AtenMulOp,AtenDivOp:Use unified template patterns
ConvertAtenBinaryScalarOpto handleAtenAddOp,AtenSubOp,AtenMulOp;Use unified template patterns
ConvertAtenDivOpto handleAtenDivOp,AtenDivIntOp,AtenDivFloatOp.