Skip to content

Conversation

@zjgarvey
Copy link
Collaborator

@zjgarvey zjgarvey commented Dec 8, 2025

Resolves #4400

Signed-off-by: zjgarvey <[email protected]>
Copy link
Member

@sahas3 sahas3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this so quickly.

It seems that the nanobind author has also fixed this issue wjakob/nanobind@06aaa39 and a new release is in the process https://github.com/wjakob/nanobind/actions/runs/20039823472

I think we can re-trigger the CI once the v2.10.1 release is done to see if the fix works for us before merging this?

@sahas3
Copy link
Member

sahas3 commented Dec 8, 2025

LGTM. Thanks for fixing this so quickly.

It seems that the nanobind author has also fixed this issue wjakob/nanobind@06aaa39 and a new release is in the process https://github.com/wjakob/nanobind/actions/runs/20039823472

I think we can re-trigger the CI once the v2.10.1 release is done to see if the fix works for us before merging this?

Oh wow, the nanobind release was quite fast, finished as I was typing my feedback. Triggered CI in https://github.com/llvm/torch-mlir/actions/runs/20037177872/job/57471075509 and it went past the nanobind failure stage.

@zjgarvey
Copy link
Collaborator Author

zjgarvey commented Dec 8, 2025

Ah, great! Thanks @sahas3 for re-running. It does look like 2.10.1 got released very quickly, so I'll close this PR.

@zjgarvey zjgarvey closed this Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI failures on main

3 participants