Skip to content

fix: correct off-by-one in is_partial_stop causing false positives #3791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alvinttang wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix: correct off-by-one in is_partial_stop causing false positives #3791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fastchat/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ def parse_gradio_auth_creds(filename: str):

def is_partial_stop(output: str, stop_str: str):
"""Check whether the output contains a partial stop str."""
for i in range(0, min(len(output), len(stop_str))):
for i in range(1, min(len(output), len(stop_str)) + 1):
if stop_str.startswith(output[-i:]):
return True
return False
Expand Down
Loading