fix: preserve uvicorn log levels instead of marking all stderr as ERROR#3796
Open
gambletan wants to merge 1 commit intolm-sys:mainfrom
Open
fix: preserve uvicorn log levels instead of marking all stderr as ERROR#3796gambletan wants to merge 1 commit intolm-sys:mainfrom
gambletan wants to merge 1 commit intolm-sys:mainfrom
Conversation
The stderr StreamToLogger was hardcoded to log everything at ERROR level, causing uvicorn INFO messages to appear as 'ERROR | stderr | INFO: ...' Changes: - Set stderr logger level to INFO instead of ERROR - Add log level detection in StreamToLogger to parse level prefixes (e.g. 'INFO:', 'WARNING:') from the message text - Use the detected level when logging, falling back to the default level Fixes lm-sys#1292
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1292
Currently, all stderr output (including uvicorn's INFO-level messages) is captured by
StreamToLoggerand re-logged atERRORlevel, causing confusing output like:Changes in
fastchat/utils.pybuild_logger()so the logger can emit messages at any level, not just ERROR+StreamToLoggervia a_detect_log_level()method that parses standard log level prefixes (INFO:,WARNING:,ERROR:,CRITICAL:,DEBUG:) from message text and uses the detected level instead of the hardcoded defaultAfter fix
Test plan
python3 -m fastchat.serve.controllerand verify uvicorn startup messages show asINFO | stderrinstead ofERROR | stderrpython3 -m fastchat.serve.openai_api_serverand verify the same