-
Notifications
You must be signed in to change notification settings - Fork 20
Update DDEV instructions, to use Composer in DDEV only #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for inspiring-euclid-d918c8 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rfay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't used localgov, but made a couple of comments to update this.
Overall, it looks like way too many words to get the job done. I think people might stumble over so much text. I'm pretty sure this is very simple and straightforward and can be described more tersely.
I don't think there needs to be any apology or defense of switching to a standard technique like DDEV or Lando, and there's not really a reason to be talking much about the docker provider, as that's more of less invisible to the user. And I would think people would already be there by now, I don't know.
It seems like this has probably been ignored for a really long time or it wouldn't still be written like this. I think it was already way too wordy, probably too many cooks in the kitchen on it.
Great suggestion. Co-authored-by: Randy Fay <[email protected]>
Co-authored-by: Randy Fay <[email protected]>
Co-authored-by: Randy Fay <[email protected]>
|
Thanks @rfay, great suggestions. And I do agree that the instruction is far too wordy, but I decided to stay focused on getting the process right. We can always create a "tighten up DDEV instructions" as a follow up :) |
What does this change?
See also DDEV issue:
Getting started
Working with DDEV
A total re-write, most importantly:
How to test
Check the updated instructions and text on the pages, and verify following them results in a working LGD installation in DDEV.
How can we measure success?
Same as above.
Have we considered potential risks?
There shouldn't be any.
Images
Accessibility