Repository navigation
refactor(acme): remove the unused LocalStack-mode scaffold - #15
Merged
Merged
Conversation
cmd/lambda only printed 'not implemented' and exited 1, and core's package comment promised Lambda and DynamoDB hooks the demo does not use.
tela
force-pushed
the
docs/samples-404-wording
branch
from
November 5, 2026 01:28
4636e24 to
684f17f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The demo uses no AWS services, and
localstack-samples/localstack-app-emulators#14removed the claims from the docs. The code still carried acmd/lambdascaffold that printed "not implemented" and exited 1, andcore/ports.gostill described Lambda and DynamoDB hooks. Nothing builds on them.Changes
refactor(acme): deleteapps/acme-commerce-lenders/cmd/lambda, and reword thecorepackage comment so it no longer describes AWS hooks.No behaviour change.
git grep -i 'aws\|lambda\|dynamo'now matches only the ApacheLICENSEtext and nothing else.Tests
Related
Follows
localstack-samples/localstack-app-emulators#14.