Skip to content

refactor(acme): remove the unused LocalStack-mode scaffold - #15

Merged
tela merged 1 commit into
mainfrom
docs/samples-404-wording
Nov 5, 2026
Merged

tela merged 1 commit into
mainfrom
docs/samples-404-wording

Conversation

@tela

@tela tela commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

The demo uses no AWS services, and localstack-samples/localstack-app-emulators#14 removed the claims from the docs. The code still carried a cmd/lambda scaffold that printed "not implemented" and exited 1, and core/ports.go still described Lambda and DynamoDB hooks. Nothing builds on them.

Changes

  • refactor(acme): delete apps/acme-commerce-lenders/cmd/lambda, and reword the core package comment so it no longer describes AWS hooks.

No behaviour change. git grep -i 'aws\|lambda\|dynamo' now matches only the Apache LICENSE text and nothing else.

Tests

make build                                          (builds every entry point, no lambda)
make check-kits                                     (every demo has cmd/kit)
go vet ./apps/acme-commerce-lenders/...             (clean)
go test -count=1 ./...  in apps/acme-commerce-lenders   (all ok)
gofmt -l apps                                       (no output)

Related

Follows localstack-samples/localstack-app-emulators#14.

cmd/lambda only printed 'not implemented' and exited 1, and core's package
comment promised Lambda and DynamoDB hooks the demo does not use.
@tela tela changed the title docs(samples): say why a 404 is expected from open source emulators refactor(acme): remove the unused LocalStack-mode scaffold Nov 5, 2026
@tela
tela force-pushed the docs/samples-404-wording branch from 4636e24 to 684f17f Compare November 5, 2026 01:28
@tela
tela merged commit adff1f6 into main Nov 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant