Repository navigation
test(workspace): exercise real Ad and Schema histories - #8022
Merged
Merged
Conversation
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
loopx-agent
requested review from
huangruiteng,
maxliux5 and
songoow
as code owners
November 4, 2026 08:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal And Delivered Outcome
The core research-reader scenario previously exercised two Grid arms from one task. It now also reads complete original Ad placement and Schemathesis histories: 255 + 94 events, including a question with 39 saved versions, a rejected local variant, inherited records and a long recording gap. All display pages and exports retain the original events; the existing reader remains the consumer.
Selection combines recency and reading complexity. The inspected newer 26 October Ad/Schema captures contain only two/four events; these record-rich sources exercise the missing cases without inventing data. This follows the reader delivered in #8003, which is already merged. Intended base:
mainat2087f540bb07dcc96e063911950ba32f3796f0ee.Author Declaration
model_agent— OpenAI Codex; signed off by LoopX Agent.research-real-benchmarkscenario reads all display pages and exports all recordsSelf-check: inspected the complete selected display-state files with typed validation and credential/private-path screening, compared their independent original bytes, and ran the checks below. Reused the existing backend, export and comparison owners; no new abstraction was needed.
Scope And Continuation
This is a complete, reversible reference-data/consumer-validation slice. The core now covers three different tasks (Grid, Ad and Schema), plus the existing historical saved Graph analysis. Ad remains
runner_invalid; Schema remainscancelled; neither run is score-countable. Source-authored confirmation is not a claim of positive benefit. The Schema recording span includes inherited records and does not measure active solver time.The broader research journey still needs installed adoption, complete corresponding trajectory publication and qualified contribution/efficiency evidence. This PR does not close that work or add a model/solver invocation. No product UI implementation changed in this follow-up.
Validation
5ea23c98bf67bc3e2c1ab709b34551a7e218c31cfinishedpublic_fixture,authorized_private_read_only,synthetic(isolated backend/process boundary only)integrationpasseduv run --extra test python -m pytest tests/presentation/test_explore_history.py tests/presentation/test_research_history_fixture.py -q— 13 checks, including real isolated SQLite/loopback reads and immutable source digestsreal_entrypointpassedLOOPX_PERSONAL_WORKSPACE_PACKAGED=1 LOOPX_PERSONAL_WORKSPACE_SCENARIO=research-real-benchmark node examples/personal-workspace-browser-smoke.mjs— 11.686s; all four history captures, existing saved Graph judgments/costs, pagination/export, 39-version comparison, keyboard return and source preservationstaticpassednpm run build:chat; touched Python Ruff check; JavaScript syntax; Git whitespace and public-boundary scanmanualpassedstaticnot_runCoverage: complete selected Explore logs only, with original Goal/run identities. No raw session transcripts, hidden evaluator, execution store or credentials are included. Installed App execution and scientific claims are outside this reference-data slice.
Frontend / Visual Evidence
UI impact: reference content changed; layout and production UI code unchanged. Before: the core reference covered two arms of one task. After: the same reader handles three tasks, real display pagination and 39 original question versions. Main history stays visible first; provenance, complete text and version comparison remain on demand. The Schema gap and missing relationships stay visible.
Current revision
5ea23c98— packaged UI with production HTTP/SQLite in disposable display-only scaffolding; not an installed/live worker. Reproduce withuv run --extra test python examples/personal-workspace-browser/research-history-backend.py --fixture apps/presentation/dashboard/src/data/fixtures/edgebench-ad-20261023-history.jsonafter building Chat. The remaining views use the corresponding Schema fixture or the core scenario.Attention review: the first view exposes the recording span/density and complete loaded count; optional originals and 39-version detail do not fill the overview. Narrow expanded titles wrap and Escape returns to the chosen record. No new layout/craft claim is made.
Type of Change
LoopX Area
Shared-authority RFC fixture impact
N/A — no authority, runtime-routing or protocol promotion change.
Boundary Checklist