Skip to content

Timestamp synthetic messages in the packaged conversation smoke - #8297

Open
huangruiteng wants to merge 1 commit into
mainfrom
codex/packaged-conversation-timestamps-20261107
Open

huangruiteng wants to merge 1 commit into
mainfrom
codex/packaged-conversation-timestamps-20261107

Conversation

@huangruiteng

Copy link
Copy Markdown
Collaborator

The installed conversation activity smoke can reach the error boundary while switching from the steward conversation to Goal Chat. Its simulated completion and queued user messages omitted the timestamp that the chat store writes for every visible message. Transcript sorting then called localeCompare on an undefined value.

Give both fixture messages the required created_at field. The existing assertions still exercise the Goal send and the original turn observer.

Validation

  • Built and installed the wheel from 32167518b3c2646fd9b6a3a6e0aaf74b258a7b70 under Python 3.11. The original fixture timed out at the Goal send after the transcript sorting exception.
  • Ran the corrected fixture against the same installed wheel. The complete conversation-activity scenario passed.
  • The local packaged workspace run passed the corrected scenario and is continuing through the remaining scenarios.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
@mergify

mergify Bot commented Nov 7, 2026

Copy link
Copy Markdown

This pull request has merge conflicts with main and cannot be merged
until they are resolved. Please rebase or merge the base branch, @huangruiteng.

Choose the remote for the base repository, not an out-of-date fork.
For a fork clone, first inspect git remote -v; upstream must point
to https://github.com/loopx-project/loopx.git. If it is absent, add it
with git remote add upstream https://github.com/loopx-project/loopx.git.
Then run:

git fetch upstream
git rebase upstream/main
# Resolve each conflict, git add the resolved files, then git rebase --continue.
git push --force-with-lease origin HEAD

For a same-repository clone whose origin points to
https://github.com/loopx-project/loopx.git, use origin instead of
upstream for fetch/rebase. If you prefer merging the base, use
git merge <base-remote>/main and push normally.

Keep the DCO Signed-off-by trailer on every commit when you rebase.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase Mergify: the pull request has merge conflicts with its base branch label Nov 7, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Mergify: the pull request has merge conflicts with its base branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants