Use brew --prefix to get brew package config path for install script#4505
Merged
lovell merged 1 commit intolovell:0.35from Mar 12, 2026
Merged
Conversation
brew --prefix to get brew package config pathbrew --prefix to get brew package config path for install script
Owner
|
Hi David, thank you for taking the time to investigate the problem and provide a solution, this will definitely improve things for those using Homebrew and building from source . Luckily this class of problem should disappear in the next release as build from source becomes opt-in, please see #4490 (comment) for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed the Bun package manager is excluding the install script for your package because it is slow.
https://github.com/oven-sh/bun/blob/a305e99af5d9dbe74ffabfa5a3c0cfdf815ac71a/src/install/postinstall_optimizer.zig#L14-L19
In Deno we were looking into making a similar optimization, but we don't believe it would be good to override your preferences just so we can do better on an install benchmark.
I was looking at the code and I believe that it should actually get the value from
brew --prefixthen./lib/pkgconfig. I'm not sure though. It is much faster to do this on my machine.