Skip to content

[rtl] Reduce the lockstep delay to 1 cycle#2363

Open
nasahlpa wants to merge 4 commits intolowRISC:masterfrom
nasahlpa:upstream_lockstep_delay
Open

[rtl] Reduce the lockstep delay to 1 cycle#2363
nasahlpa wants to merge 4 commits intolowRISC:masterfrom
nasahlpa:upstream_lockstep_delay

Conversation

@nasahlpa
Copy link
Member

@nasahlpa nasahlpa commented Feb 3, 2026

Before this PR, a lockstep delay of 2 cycles was used when the lockstep mechanism was active (which is the case when SecureIbex = 1). This PR reduces the delay to 1 cycle to save area.

@nasahlpa nasahlpa changed the title [rtl] Reduce the lockstep delay to 1 [rtl] Reduce the lockstep delay to 1 cycle Feb 3, 2026
@nasahlpa nasahlpa force-pushed the upstream_lockstep_delay branch from fb477c4 to 4842251 Compare February 3, 2026 11:46
Copy link
Contributor

@vogelpi vogelpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The changes are identical to what I've reviewed and approved previously, thanks @nasahlpa !

@nasahlpa nasahlpa enabled auto-merge February 5, 2026 06:13
@nasahlpa nasahlpa force-pushed the upstream_lockstep_delay branch from 4842251 to 33b3581 Compare February 6, 2026 14:25
@nasahlpa nasahlpa disabled auto-merge February 6, 2026 14:25
Move and reword this comment as it makes more sense at the line where
we actually enable the lockstep comparison.

Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
This enables us to switch between different lockstep delays more
easily.

Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
This commit reduces the lockstep delay from two cycles to one cycle to
reduce the area overhead of the lockstep. For this, the RTL is adapted such
that `LockstepOffset = 1` works, which was not the case before.

Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
Two fixes:
- When `LockstepOffset = 1`, the `u_rst_shadow_cnt` instance does not
  exist.
- Fix the `u_rst_shadow_cnt` instance path as it is now in
  `gen_reset_counter`.

Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
@nasahlpa nasahlpa force-pushed the upstream_lockstep_delay branch from 33b3581 to 22764e6 Compare February 6, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants