Repository navigation
Conversation
The bridge now reports tab activation, and web_scan uses that instead of the last tab the agent operated on.
Author
|
Closing this to narrow my open-source work to fewer projects. Anyone is welcome to pick the change up if it's useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #793.
web_scan reported
active_tabas the last tab the agent touched. If the user switched tabs in Chrome, the scan still read the old page.The MV3 bridge now includes
active/windowIdand listens fortabs.onActivatedandwindows.onFocusChanged. TMWebDriver updatesdefault_session_idfrom that, and web_scan marks the matching tab.Tested with
frontends/tests/test_web_scan_active_tab.py.