Repository navigation
Conversation
ebellm
reviewed
Mar 23, 2026
| target=lsst.meas.algorithms.SubtractBackgroundTask, | ||
| doc="Task to perform final background subtraction, after first detection pass.", | ||
| ) | ||
| doRemoveCosmicRays = pexConfig.Field( |
Contributor
There was a problem hiding this comment.
should this be doMaskCosmicRays, doFindCosmicRays, or doDetectCosmicRays` since your default below is not to interpolate over them?
Contributor
Author
There was a problem hiding this comment.
I'll change it to doFindCosmicRays
isullivan
force-pushed
the
tickets/DM-54428
branch
from
March 23, 2026 23:11
e7459e1 to
6f7d17f
Compare
kherner
approved these changes
Mar 25, 2026
| # Add CR-like shape and check that CR is detected | ||
| # Pick two locations on top of sources, since that is what is likely to | ||
| # be missed in the first stage of CR rejection. | ||
| difference.image.array[crX0:crX0+1, crY0:crY0+5] += 500 |
Contributor
There was a problem hiding this comment.
What's magic about 500 here? Should it just match the flux level instead? Same comment for the next line.
Contributor
Author
There was a problem hiding this comment.
Good question! It's just a large enough number that it triggers the CR code. I'll add a comment.
isullivan
force-pushed
the
tickets/DM-54428
branch
from
March 25, 2026 23:13
6f7d17f to
c235b27
Compare
Contributor
Author
|
GitHub had an error when I clicked the "Merge pull request" button, and DID merge the PR but did not record that it did here. |
Contributor
Author
|
Closing this PR, since it is in fact merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.