Skip to content

Conversation

@dtm
Copy link
Contributor

@dtm dtm commented Oct 6, 2019

Hi,

This PR adds the ability to build ProvToolbox in a docker container to avoid having to install its dependencies locally. make -f Makefile-docker build will run the equivalent of mvn package and make -f Makefile-docker extract will extract the provconvert artefact.

I've tried to make use of docker layer caching so that mvn dependencies are cached between builds (ie whilst you are making source changes). However, I've not been able to eliminate all the downloads.

I had to stop the docker-service-translator target from building since it, itself, uses docker. I tried using mvn -pl -docker-service-translator ... but this did not seem to work so I had to use the sed (sledgehammer) to remove docker-service-translator from modules-services/pom.xm (cracked nut).

Regards,
Danius

@lucsilubi
Copy link

Hi Dan,
Thanks for this. I have been thinking about it, it's a great idea, especially, as some struggle to compile ProvToolbox, in particular on windows. However, I wonder whether we could use the travis set, since all the dependencies are already declared in .travis.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants