fix: point README badge to stable demo/build/latest/ instead of volatile commit SHA - #6
Merged
Merged
Conversation
… URL Agent-Logs-Url: https://github.com/luke-b/DosTest/sessions/50fde0f7-fd08-4ca9-8a43-7a44b4932b85 Co-authored-by: luke-b <1448891+luke-b@users.noreply.github.com>
Agent-Logs-Url: https://github.com/luke-b/DosTest/sessions/50fde0f7-fd08-4ca9-8a43-7a44b4932b85 Co-authored-by: luke-b <1448891+luke-b@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Play latest build" badge was hardcoded to a commit-SHA URL (
demo/build/81daf9b/), and theupdate-readmeCI job kept rewriting it with the newest SHA on every push — meaning any stale SHA (failed deploy, deleted build, etc.) results in a 404. A stabledemo/build/latest/redirect already existed but was never wired to the badge.Changes
README.md: Badge URL changed fromdemo/build/81daf9b/→demo/build/latest/borland-dos-pipeline.yml(update-readmejob):DEMO_URLhardcoded todemo/build/latest/; removed now-unusedSHORT_SHAvariable from that step (still used in the commit message step below it)