Skip to content

Conversation

@a2
Copy link

@a2 a2 commented Feb 18, 2012

No description provided.

a2 added 3 commits January 20, 2012 20:54
Signed-off-by: Alexsander Akers <[email protected]>
Signed-off-by: Alexsander Akers <[email protected]>
@lukeredpath
Copy link
Owner

Thanks a lot, this looks useful. Before I can merge, I'd appreciate it if you'd make some style changes. The spacing of your methods is a bit off and doesn't match the rest of the code.

It should be:

- (void)addSwipeGestureRecognizer:(UISwipeGestureRecognizerDirection)direction;

Not:

- (void) addSwipeGestureRecognizer: (UISwipeGestureRecognizerDirection) direction;

For example. Also don't leave spaces in methods between the arguments, e.g.;

[self addSwipeGestureRecognizer:UISwipeGestureRecognizerDirectionRight];

Instead of:

[self addSwipeGestureRecognizer: UISwipeGestureRecognizerDirectionRight];

Please also keep opening braces of statements (if/while/switch etc.) on the same line. Only opening braces for methods should be on a new line. Always uses braces for if statements.

There's also no need to modify the copyright statements or LICENSE file. I can add your name to a contributors list in the README.

Thanks a lot.

@a2
Copy link
Author

a2 commented Feb 18, 2012

Wouldn't it just be easier to merge the pull request and make the changes? I'm sure it would be easier for both of us.

@lukeredpath
Copy link
Owner

I'm too busy right now so it will have to wait, thanks. Generally speaking, it's much more helpful when contributing to try and stick to the style that has been used by the original author - it avoids issues like these. Thanks.

@ashishfission
Copy link

@lukeredpath how to add buttons behinde the cell?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants