Conversation
If there is an I/O error on stdout or stderr, return a non-zero status so that udev can avoid trusting the values printed.
If the output of `dmsetup splitname` cannot be trusted, the safest option is to disable all lvm2 rules.
In this cased the safest option is to disable most udev rules.
All kernels Qubes OS uses are new enough to have the dm/ subdirectory.
|
Note - github is not 'primary' git source for lvm2 codebase - it's a some mirrored copy. For best review is better to actually post patches on linux-lvm@redhat.com. Some initial comment - we can't accept 'dmsetup' version - we rather want to have fixed those code paths giving wrong result - in some cases some code unfortunatelly does not correctly uses log_error or log_debug - thus giving 'error' result purely based on usage is these functions is invalid. 2nd. can be considered - although splitname should never fail - if it does - system is already in seriously deeper troubles.. 3rd. cookie is always there - unless you use non-linux kernel with these rules - but rule can be considered for safety. 4th. not acceptable as we do try to keep things working even with limited functionality |
Can you explain? This is purely about fixing |
2 participants
This makes the udev rules more robust against various unsafe error conditions.