Add support for API version v1beta2 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is purely the results of running `go mod tidy` and `go mod vendor`. The only reason for doing this is to update the module github.com/k8snetworkplumbingwg/multi-networkpolicy to a version in which v1beta2 is supported.
This commit updates all references to the import to use the new import alias of "v1beta2" and "multiinformerv1beta2". Additionally, there are 5 or 6 small changes suggested by the Go linter in vscode.
This commit simply adds a small conditional checking whether port.EndPort is not nil, in which case it writes the iptable rule with flag `--dport N:N`, else it write the same iptables rule as before.
Verfies that a port specification which includes endPort writes the expected iptables rule with `--dport N:N`, and that one that doesn't include endPort writes the normal iptables rule with `--dport N`.
This was an oversight on my part, as our use case only requires ingress rules, but the functionality needs to be available for both ingress and egress rules. Additionally, I reformated the logic, per PR reviewer suggestions, to eliminate some redudnacy and make the code cleaner and more readable.
nkinkade
requested review from
robertodauria and
stephen-soltesz
and removed request for
stephen-soltesz
robertodauria
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only difference between v1beta2 and v1beta1, apparently, is the addition of
endPortfor port specifications, allowing the port ranges. There is an open PR for these changes with the upstream repo, but it is not clear that it will ever get merged.The changeset in this PR represents the version of multi-networkpolicy that is currently running in sandbox and staging, and this PR is just trying to normalize the deployment from this repo instead of upstream.