chore: bump tmp and eslint in /plugin#88
Conversation
PR SummaryMedium Risk Overview This is a dependency-only change for the Cordova plugin package; the existing Reviewed by Cursor Bugbot for commit fa7c26e. Bugbot is set up for automated code reviews on this repo. Configure here. |
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/plugin/multi-ce2a7fe9d8
branch
from
2e22188 to
9d31fc6
Compare
|
@dependabot rebase |
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/plugin/multi-ce2a7fe9d8
branch
from
9d31fc6 to
e6b2e43
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| }, | ||
| "devDependencies": { | ||
| "eslint": "^4.19.1", | ||
| "eslint": "^10.4.1", |
There was a problem hiding this comment.
ESLint 10 breaks legacy config
High Severity
Bumping eslint to ^10.4.1 leaves npm test invoking ESLint 10 while the repo still configures linting via the root .eslintrc.js and eslint-config-standard v11. ESLint 10 no longer loads legacy eslintrc files, so the eslint script is likely to fail before any rules run. ESLint 10 also requires newer Node versions than the 18.x CI matrix entry.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit e6b2e43. Configure here.
Removes [tmp](https://github.com/raszi/node-tmp). It's no longer used after updating ancestor dependency [eslint](https://github.com/eslint/eslint). These dependencies need to be updated together. Removes `tmp` Updates `eslint` from 4.19.1 to 10.4.1 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v4.19.1...v10.4.1) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.4.0 dependency-type: direct:development - dependency-name: tmp dependency-version: dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/plugin/multi-ce2a7fe9d8
branch
from
e6b2e43 to
c281139
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fa7c26e. Configure here.
| }, | ||
| "bin": { | ||
| "eslint": "bin/eslint.js" | ||
| }, | ||
| "engines": { | ||
| "node": ">=4" | ||
| "node": "^20.19.0 || ^22.13.0 || >=24" | ||
| }, |
There was a problem hiding this comment.
Node eighteen incompatible with ESLint
Medium Severity
The lockfile pins eslint 10.4.1 with engines ^20.19.0 || ^22.13.0 || >=24, but the pull-request workflow still runs JS tests on Node 18.x. That matrix leg is outside ESLint 10’s supported Node range, so install or npm test on 18.x can fail after this bump.
Reviewed by Cursor Bugbot for commit fa7c26e. Configure here.
1 participant
Removes tmp. It's no longer used after updating ancestor dependency eslint. These dependencies need to be updated together.
Removes
tmpUpdates
eslintfrom 4.19.1 to 10.4.1Release notes
Sourced from eslint's releases.
... (truncated)
Commits
4a3d15a10.4.143e7e2bBuild: changelog update for 10.4.1e557467fix: update@eslint/plugin-kitversion to 0.7.2 (#20930)b0e466btest: adddataproperty to invalid tests cases for rules (#20924)d4ce898fix: propagate failures from delegated commands (#20917)f4f3507fix: prefer-arrow-callback invalid autofix with newline afterasync(#20916)f78838btest: add CodePath type coverage (#20904)61b0adddocs: remove deprecated rule from related rules ofmax-params(#20921)1daa4bdchore: updateeslint-plugin-eslint-commentstest data to latest commit (#20...002942cci: declare contents:read on update-readme workflow (#20919)Maintainer changes
This version was pushed to npm by eslintbot, a new releaser for eslint since your current version.