Open
Conversation
add href so the user gets redirected to home when clicking the button they are redirected
Redirect to home when clicking logo
|
This pull request includes a minor change to the |
|
PR Summary: This PR updates the Navbar component so that clicking the logo now redirects users to the homepage via an added href attribute. • Changed the Menu.Item wrapping the logo to include href="http://github-help-wanted.com/". |
getpantoai
reviewed
Jul 3, 2025
| <Menu attached="top" inverted as={HeaderComponent}> | ||
| <Container> | ||
| <Menu.Item as="a" header> | ||
| <Menu.Item as="a" href="http://github-help-wanted.com/" header> |
There was a problem hiding this comment.
Consider using a configuration constant for the home URL rather than hardcoding "http://github-help-wanted.com/" for easier maintenance and environment flexibility
<Menu.Item as="a" href={links.internal.home_url} header>
<Logo size="large" />
</Menu.Item>Assuming links.internal.home_url is defined in your constants. If not, add it there and use it here for maintainability.
|
Reviewed up to commit:233f200e5e2decb339a2be0976619ef109b93b12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously clicking on the logo on navbar didnt do anything, now it redirects to the home page (http://github-help-wanted.com/)
I tested it and it could successfully redirect from localhost:3100 to http://github-help-wanted.com/