Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades the PostGraphile Docker image to a stable v2 tag and migrates JWT key material/references from RS256 (RSA) to ES256 (EC) across the dev stack (with partial production reference updates).
Changes:
- Update production PostGraphile image from
2.0.0-beta.1to2.0.0. - Replace RS256 public key mounts with ES256 public key mounts in the development stack.
- Replace the development PostGraphile JWT private key secret with an EC (ES256) private key and add the corresponding ES256 public key file (removing the RS256 one).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/production/production.yml | Bumps PostGraphile image to 2.0.0 and updates a commented JWT public-key mount reference. |
| src/development/stack.yml | Switches dev service mounts from jwtRS256.key.pub to jwtES256.key.pub. |
| src/development/secrets/postgraphile/jwt-secret.secret | Replaces the dev JWT signing key from RSA to EC (ES256). |
| src/development/configurations/postgraphile/jwtRS256.key.pub | Removes the old RS256 public key file. |
| src/development/configurations/postgraphile/jwtES256.key.pub | Adds the new ES256 public key file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dargmuesli
force-pushed
the
feat/postgraphile/v2
branch
from
21a512a to
66a6a3f
Compare
|
🎉 This PR is included in version 17.0.0-beta.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 17.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request migrates the JWT signing algorithm for PostGraphile and related services from RSA (RS256) to Elliptic Curve (ES256). It updates all relevant configuration files, secrets, and public key references to use new ES256 keys instead of the previous RS256 keys. Additionally, it updates the PostGraphile Docker image to a stable release version.