Draft
Conversation
Co-authored-by: magnesj <1793152+magnesj@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Create a plan on how to add file support for Resqml files
Add RESQML EPC file support infrastructure
Mar 3, 2026
Owner
|
@copilot use fesapi as submodule in ThirdParty |
Co-authored-by: magnesj <1793152+magnesj@users.noreply.github.com>
Author
Done in commit 920f238. Added |
…nto copilot/fix-1793152-87388597-2ba58695-6215-41b7-b6b3-cb26ad7646a0
…nto copilot/fix-1793152-87388597-2ba58695-6215-41b7-b6b3-cb26ad7646a0
- Initialize ThirdParty/fesapi submodule (v2.14.1.0) - Fix fesapi CMAKE_SOURCE_DIR usage: use CMAKE_CURRENT_SOURCE_DIR so FESAPI_ROOT_DIR and CMAKE_MODULE_PATH resolve correctly as subdirectory - Fix fesapi target name: FesapiCpp (not fesapi) - Add missing vcpkg dependencies: hdf5, minizip, boost-uuid - Add fesapi src include path in ApplicationLibCode - Add RifResqmlFileTools as friend class in RigMainGrid - Update RifResqmlFileTools to fesapi v2.14 API: DataObjectRepository, loadBlockInformation/getXyzPointsOfBlock, getInt32ValuesOfPatch - Fix FESAPI_STATIC propagation: change PRIVATE to PUBLIC so consumers do not see symbols as dllimport when linking the static library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RESQML (
.epc) files are an industry-standard format for reservoir data exchange with no existing support in ResInsight. This PR adds the full import pipeline, conditionally compiled against the fesapi library, which is included as a git submodule inThirdParty/fesapi.New components
RifResqmlFileTools— reads IJK grid geometry and continuous/discrete cell properties from EPC files. Guarded by#ifdef RESINSIGHT_HAVE_RESQML; returns a descriptive error message when fesapi is not presentRimResqmlCase—RimEclipseCasesubclass following theRimRoffCasepattern; loads grid + properties, computes depth-related results and cell volumes on openRicImportResqmlCaseFeature— UI command opening a.epcfile dialog, wired into the Import → RESQML Grid Models menuWired into existing infrastructure
RiaDefines::ImportFileType::RESQML_FILE = 1 << 11;.epcextension detected inobtainFileTypeFromFileNameRiaImportEclipseCaseTools—openResqmlCasesFromFileNames/openResqmlCaseFromFileNameRicImportGeneralDataFeature— dispatches.epcfiles throughopenResqmlFilesFromFileNames; adds"RESQML EPC File (*.epc)"filterRicAddEclipseInputPropertyFeature— enabled forRimResqmlCaseselectionsCMakeLists_files.cmakefiles updatedCMake
fesapi is included as a git submodule at
ThirdParty/fesapiand built as part of the ResInsight build when RESQML support is enabled:Sets
RESINSIGHT_HAVE_RESQMLcompile definition and builds fesapi from source. Unneeded fesapi build targets (tests, examples, Java/dotnet wrappers) are disabled automatically.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.