Scroll the ethernet text with the wifi list + other wifi fixes #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea here is that the reset button is always on top of the ethernet text and when we are showing a wifi list the ethernet text is the header element of the list (so that it scrolls with the list). We make two copies of the ethernet text so that we also have a non scrolling version to show when the list is not visible (though I am not entirely clear on why we can't always show the list or whether we really need the ethernet text in the cases where we don't show the list). This also changes around the logic to disable attempted use of wifi while ethernet is attached because this really does not work well, and changes the scanning logic to separately track whether we are actively scanning and whether we are currently connected, because apparently the rescan button has been completely unusable since 1.5 if you aren't already connected to wifi. This also fixes the top bar title.
Contributor
|
While testing this, I found that the Wifi list still showed up when connected to the ethernet and I was able to tap a wifi name and connect to it. The ethernet dropped and the wifi connection took over all the while the cable was plugged in. Is this intended? Conman doesn't prioritize ethernet over wifi if a cable is connected? The re-scan button is disabled when the ethernet is connected though, so the wifi list should also mirror it if we want to block this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is that the reset button is always on top of the ethernet text and when we are showing a wifi list the ethernet text is the header element of the list (so that it scrolls with the list). We make two copies of the ethernet text so that we also have a non scrolling version to show when the list is not visible (though I am not entirely clear on why we can't always show the list or whether we really need the ethernet text in the cases where we don't show the list).
This also changes around the logic to disable attempted use of wifi while ethernet is attached because this really does not work well, and changes the scanning logic to separately track whether we are actively scanning and whether we are currently connected, because apparently the rescan button has been completely unusable since 1.5 if you aren't already connected to wifi. This also fixes the top bar title.