use the GIO target instead of lib/include variables#129
Open
pslldq wants to merge 1 commit intomaliit:masterfrom
Open
use the GIO target instead of lib/include variables#129pslldq wants to merge 1 commit intomaliit:masterfrom
pslldq wants to merge 1 commit intomaliit:masterfrom
Conversation
Use the GIO target instead of the lib/include variables, as it matches the modern CMake approach. Furthermore it also makes it clear to CMake that we're linking against an external target, so CMake doesn't try to add the include/library paths to the gernerated MaliitGLibTargets.cmake file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the GIO target instead of the lib/include variables, as it matches the modern CMake approach. Furthermore it also makes it clear to CMake that we're linking against an external target, so CMake doesn't try to add the include/library paths to the gernerated
MaliitGLibTargets.cmakefile.