Skip to content

Fix for Issue #640 - config.xml misformatted#641

Merged
Ana06 merged 1 commit into
mandiant:mainfrom
thomasklemenc:fix-config
Jan 20, 2025
Merged

Fix for Issue #640 - config.xml misformatted#641
Ana06 merged 1 commit into
mandiant:mainfrom
thomasklemenc:fix-config

Conversation

@thomasklemenc

Copy link
Copy Markdown
Contributor
  • Move the license after the opening XML tag. Per spec, first characters of an XML file must be <?xml

... encoding must begin with an XML encoding declaration, in which the first characters must be '<?xml' ...

  • Remove the BOM as it is not needed for UTF-8 encoded XML files

Fixes #640

CLA has been signed.

@Saad-Alaref Saad-Alaref left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done the same thing before reading this pull request, and it does indeed work.
This also fixes #642 and #643 since they are duplicates of #640.

@Ana06 Ana06 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems I broke this file in #638, breaking FLARE-VM 🙈 I used addlicense to add the headers and it seems a <feff> (Byte Order Mark (BOM)) in this file caused that it added the header in the wrong way, breaking the file. I am not sure if this a bug in addlicense as the BOM likely shouldn't be there, as I also think it is not needed. In any case, @tgecko thanks for reporting and fixing the bug! 💐 @Saad-Alaref thank for confirming the fix work and the additional details 💐

@Ana06
Ana06 merged commit 846d20e into mandiant:main Jan 20, 2025
@JackStuart

Copy link
Copy Markdown

Hi @Ana06, It was a bug in Addlicence - I have created a PR to fix it. Maybe you might have more traction getting someone in Google to take a look at it because it hasn't been updated in 2.5 years

google/addlicense#166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken default config.xml

4 participants