Support Layout and Format nodes in text and shield symbolizers#62
Closed
hollinger wants to merge 2 commits intomapnik:masterfrom
Closed
Support Layout and Format nodes in text and shield symbolizers#62hollinger wants to merge 2 commits intomapnik:masterfrom
hollinger wants to merge 2 commits intomapnik:masterfrom
Conversation
…nd shield symbolizers. Properties are defined for child elements in the same format as symbolizer properties. Each element contains data about one or more psuedo-elements that can be used to create the element with carto css. An array is defined inside of each symbolizer and element that can potentially contain child elements to specifiy which types of elements they support.
Member
|
on my radar to help review and land soon as part of Mapnik 3.x release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a potential addition, which corresponds with mapbox/carto#358. The goal is to support definition of layout and format nodes in carto, as discussed in mapbox/carto#347.
What is being added here is child element types (currently layout and format), along with their attributes, that can be defined inside of text and shield symbolizers in mapnik XML. Also added are css pseudo-elements that can be used to create and define these elements in carto. In mapnik, format and layout elements can be contained within text and shield symbolizers, and they can also be nested inside of each other. The child-elements lists are used to control which types of elements can go where.
Along with the proposed changes to carto compiler (mapbox/carto#358), this is designed to allow for expansion to other xml tags that can be defined inside of a symbolizer. In particular, a 'placement' element type could easily be added to define alternate placements for list placement mode (see #45 and mapbox/carto#238).