Construct pure virtual methods in inherited classes#340
Closed
rcalixte wants to merge 6 commits into
Closed
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unfortunately ends up as a sort of breaking change. Now that the base implementations are defined, they are returning 0 in some cases. The result is that not setting an override means a 0 value being returned for something like the column count, leading to an empty-looking model where Qt's private default may return 1 (in the case of QAbstractListModel but not QAbstractTableModel). The fix is mechanical but it's still a breaking change. I've updated the examples that I could find that were impacted.
While it's not strictly marshalling in the purest sense, the tests are for validation that can otherwise only be seen visually. Would it make sense to split the tests into a new testing nomenclature?
cc @arnetheduck