Skip to content

fix(ios): avoid shared pointer Bool conversion in generated Swift bridges #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrousavy merged 1 commit into from
Sep 5, 2026
Merged

fix(ios): avoid shared pointer Bool conversion in generated Swift bridges #1585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/nitrogen/src/syntax/swift/SwiftHybridObjectBridge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ ${hasBase ? `open class ${name.HybridTSpecCxx} : ${baseClasses.join(', ')}` : `o
*/
public func getCxxPart() -> bridge.${bridge.specializationName} {
let cachedCxxPart = self.__cxxPart.lock()
if Bool(fromCxx: cachedCxxPart) {
if cachedCxxPart.use_count() > 0 {
return cachedCxxPart
} else {
let newCxxPart = bridge.${bridge.funcName}(self.toUnsafe())
Expand Down
2 changes: 1 addition & 1 deletion ...e-nitro-test-external/nitrogen/generated/ios/swift/HybridSomeExternalObjectSpec_cxx.swift
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/react-native-nitro-test/nitrogen/generated/ios/swift/HybridBaseSpec_cxx.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ open class HybridBaseSpec_cxx {
*/
public func getCxxPart() -> bridge.std__shared_ptr_HybridBaseSpec_ {
let cachedCxxPart = self.__cxxPart.lock()
if Bool(fromCxx: cachedCxxPart) {
if cachedCxxPart.use_count() > 0 {
return cachedCxxPart
} else {
let newCxxPart = bridge.create_std__shared_ptr_HybridBaseSpec_(self.toUnsafe())
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-nitro-test/nitrogen/generated/ios/swift/HybridChildSpec_cxx.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ open class HybridChildSpec_cxx : HybridBaseSpec_cxx {
*/
public func getCxxPart() -> bridge.std__shared_ptr_HybridChildSpec_ {
let cachedCxxPart = self.__cxxPart.lock()
if Bool(fromCxx: cachedCxxPart) {
if cachedCxxPart.use_count() > 0 {
return cachedCxxPart
} else {
let newCxxPart = bridge.create_std__shared_ptr_HybridChildSpec_(self.toUnsafe())
Expand Down
2 changes: 1 addition & 1 deletion ...s/react-native-nitro-test/nitrogen/generated/ios/swift/HybridPlatformObjectSpec_cxx.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ open class HybridPlatformObjectSpec_cxx {
*/
public func getCxxPart() -> bridge.std__shared_ptr_HybridPlatformObjectSpec_ {
let cachedCxxPart = self.__cxxPart.lock()
if Bool(fromCxx: cachedCxxPart) {
if cachedCxxPart.use_count() > 0 {
return cachedCxxPart
} else {
let newCxxPart = bridge.create_std__shared_ptr_HybridPlatformObjectSpec_(self.toUnsafe())
Expand Down
2 changes: 1 addition & 1 deletion ...act-native-nitro-test/nitrogen/generated/ios/swift/HybridRecyclableTestViewSpec_cxx.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ open class HybridRecyclableTestViewSpec_cxx {
*/
public func getCxxPart() -> bridge.std__shared_ptr_HybridRecyclableTestViewSpec_ {
let cachedCxxPart = self.__cxxPart.lock()
if Bool(fromCxx: cachedCxxPart) {
if cachedCxxPart.use_count() > 0 {
return cachedCxxPart
} else {
let newCxxPart = bridge.create_std__shared_ptr_HybridRecyclableTestViewSpec_(self.toUnsafe())
Expand Down
2 changes: 1 addition & 1 deletion ...-native-nitro-test/nitrogen/generated/ios/swift/HybridTestObjectSwiftKotlinSpec_cxx.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ open class HybridTestObjectSwiftKotlinSpec_cxx {
*/
public func getCxxPart() -> bridge.std__shared_ptr_HybridTestObjectSwiftKotlinSpec_ {
let cachedCxxPart = self.__cxxPart.lock()
if Bool(fromCxx: cachedCxxPart) {
if cachedCxxPart.use_count() > 0 {
return cachedCxxPart
} else {
let newCxxPart = bridge.create_std__shared_ptr_HybridTestObjectSwiftKotlinSpec_(self.toUnsafe())
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-nitro-test/nitrogen/generated/ios/swift/HybridTestViewSpec_cxx.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ open class HybridTestViewSpec_cxx {
*/
public func getCxxPart() -> bridge.std__shared_ptr_HybridTestViewSpec_ {
let cachedCxxPart = self.__cxxPart.lock()
if Bool(fromCxx: cachedCxxPart) {
if cachedCxxPart.use_count() > 0 {
return cachedCxxPart
} else {
let newCxxPart = bridge.create_std__shared_ptr_HybridTestViewSpec_(self.toUnsafe())
Expand Down
Loading