fix: Run legacy Android ASan on API 33 - #1600
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API 36 x86_64 ASan job has failed during app startup before running any tests. Run the ASan row on API 33, keep the Default row on API 36, and preserve manual device overrides. This extracts only the emulator configuration from #1530.
The same API 33 configuration passed both Android rows in three earlier runs: 32909241009, 32909937474, and 32910631876. Those runs also contained the separate test fixes from #1530; they establish prior configuration coverage, not a guarantee that every test on this standalone PR is stable.
Android now recommends HWASan, which requires ARM64. The existing CI emulator is x86_64, so this keeps its legacy ASan coverage using the previously tested image. ASan remains unsupported by Android; the evidence for this image choice is the previous successful CI runs.
Validation:
actionlintandgit diff --checkpass. The fresh ASan Harness step passed. The unchanged Default row failed duringadb installbefore executing tests; its log does not include the underlying installation error.