Skip to content

profileFetch should tolerate unavailable Hermes sampling APIs and failed dumps #193

Description

@OskarEichler

HermesInternal being present does not imply its sampling methods are available. profileFetch currently calls them unchecked, uses global rather than globalThis, reports a profilePath even if dumping fails, and a disable failure can mask the wrapped function's original result/error. Overlapping calls also share one global profiler. I plan to make profiling best-effort, avoid overlapping ownership, preserve the wrapped function's outcome, and report a path only after a successful dump. Controlled profiler doubles will validate success, missing APIs, exceptions and nested calls.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions