-
Notifications
You must be signed in to change notification settings - Fork 822
improvement: poetry package list support for v2 #7144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement: poetry package list support for v2 #7144
Conversation
|
I have read the CLA Document and I hereby sign the CLA |
for more information, see https://pre-commit.ci
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dmadisetti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tests! LGTM
dmadisetti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, would you mind grabbing the lint errors that popped up? You can run make py-check locally? Also left a suggestion if you just want to apply that, but needs an additional change to go with
Co-authored-by: Dylan Madisetti <[email protected]>
for more information, see https://pre-commit.ci
|
Hey @dmadisetti 👋 I think I've handled them but please let me know. I'm still trying to familiarize myself with the dev environment so let me know if there's something I'm missing!
|
|
@robd518 I think that was the only issue (which is now fine) |
|
@dmadisetti If you're referring to this line, I believe it's committed and ready to go but let me know if you're seeing seomthing different or if I'm just missing something. :) |
for more information, see https://pre-commit.ci
dmadisetti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry this slipped. LGTM

Fixes #7090
📝 Summary
Poetry 1.x and 2.x handle the
poetry showcommand differently. The currentPoetryPackageManagerimplementation is fine but with the release of Poetry 2.0 in January the current implementation breaks. This PR will fix issue #7090 - and as a side benefit - improve thePoetryPackageManagerclass.🔍 Description of Changes
Poetry version detection:
The manager now detects the installed Poetry version (1.x vs 2.x) at runtime.
Adaptive command generation:
poetry show --no-dev.poetry show --without dev.Group(s) not found, this indicates that no dev group is defined — in that case, fall back topoetry showto capture all installed packages.Fallback behavior:
If version detection or command inference fails for any reason, default gracefully to poetry show.
This ensures PoetryPackageManager works consistently across Poetry versions 1.x → 2.x and avoids breaking when no dependency groups are defined.
📋 Checklist